[all-commits] [llvm/llvm-project] 68cfb6: Fixes assertion that arose from bad FIR being cons...

[Eric Schweitz via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 68cfb6a8e567531ab77fa5ac1eb8bd57844ccb4d
      https://github.com/llvm/llvm-project/commit/68cfb6a8e567531ab77fa5ac1eb8bd57844ccb4d
  Author: Eric Schweitz <eschweitz at nvidia.com>
  Date:   2022-06-10 (Fri, 10 Jun 2022)

  Changed paths:
    M flang/lib/Optimizer/Builder/FIRBuilder.cpp
    M flang/test/Lower/allocatable-assignment.f90
    M flang/test/Lower/array-elemental-calls-2.f90
    M flang/test/Lower/derived-assignments.f90
    M flang/test/Lower/structure-constructors.f90

  Log Message:
  -----------
  Fixes assertion that arose from bad FIR being constructed.

* Fix assertion strings.

* Fixes assertion that arose from bad FIR being constructed.

With the default member-wise component assignment, the LHS and RHS may
be compatible but distinct types. This change to lowering manages both
the LHS and RHS independently rather than assume the two types are
identical. This avoids creating bogus FIR and asserting/crashing in
codegen.

Update the tests with the member-wise copy code.

This patch is part of the upstreaming effort from fir-dev branch.

Co-authored-by: Eric Schweitz <eschweitz at nvidia.com>

Reviewed By: jeanPerier

Differential Revision: https://reviews.llvm.org/D127297