[all-commits] [llvm/llvm-project] 457f38: [lld][WebAssembly] Revert moving of data relocatio...

Sam Clegg via All-commits all-commits at lists.llvm.org
Thu Jun 9 17:50:06 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 457f38a7b0ef7d845832738c0a8add469b31bbcc
      https://github.com/llvm/llvm-project/commit/457f38a7b0ef7d845832738c0a8add469b31bbcc
  Author: Sam Clegg <sbc at chromium.org>
  Date:   2022-06-09 (Thu, 09 Jun 2022)

  Changed paths:
    M lld/test/wasm/data-segments.ll
    M lld/test/wasm/pie.ll
    M lld/test/wasm/shared-weak-symbols.s
    M lld/wasm/Writer.cpp

  Log Message:
  -----------
  [lld][WebAssembly] Revert moving of data relocations to start function

Back in https://reviews.llvm.org/D117412 we moved the application of
data reloctions to the wasm start function.

However, because the dynamic linker doesn't know the final addresses
at module instantiation time, this proved to be too early and the
relocations could be applied with the wrong values.

Fixes: https://github.com/emscripten-core/emscripten/issues/17150

Differential Revision: https://reviews.llvm.org/D127333




More information about the All-commits mailing list