[all-commits] [llvm/llvm-project] 214be9: [libc] Add compile options to pthread_create target.

Siva Chandra via All-commits all-commits at lists.llvm.org
Thu Jun 9 10:26:59 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 214be9d1cd1601a5b4f8c1b598c3264affdbcc0a
      https://github.com/llvm/llvm-project/commit/214be9d1cd1601a5b4f8c1b598c3264affdbcc0a
  Author: Siva Chandra Reddy <sivachandra at google.com>
  Date:   2022-06-09 (Thu, 09 Jun 2022)

  Changed paths:
    M libc/src/pthread/CMakeLists.txt

  Log Message:
  -----------
  [libc] Add compile options to pthread_create target.

The compile options now match that of thrd_create. Two compile options
are of importance:
1. -O3 - This is required so that stack is not used between the clone
   syscall and the start function in the child thread.
2. -fno-omit-frame-pointer - This is required so that we can sniff out
   the thread start args from the child thread's stack memory.

Without these two options, pthread_create will exhibit flaky behavior.

Reviewed By: lntue, michaelrj

Differential Revision: https://reviews.llvm.org/D127381




More information about the All-commits mailing list