[all-commits] [llvm/llvm-project] 553d51: [cmake] Add missing dependencies to objlib in add_...

Florian Hahn via All-commits all-commits at lists.llvm.org
Thu Jun 9 01:24:36 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 553d5161ee23694953ff7493f50d077e85e26fce
      https://github.com/llvm/llvm-project/commit/553d5161ee23694953ff7493f50d077e85e26fce
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2022-06-09 (Thu, 09 Jun 2022)

  Changed paths:
    M llvm/cmake/modules/AddLLVM.cmake

  Log Message:
  -----------
  [cmake] Add missing dependencies to objlib in add_llvm_executable.

After f06abbb393800b0d466c88e283c06f75561c432c I have been seeing build
failures due to the obj.clang target missing a dependency on
tools/clang/clang-tablegen-targets.

This appears to be due to the fact that LLVM_COMMON_DEPENDS are not added
as dependencies to the object library.

This patch uses the same logic as llvm_add_library to register
dependencies for object libraries.

Reviewed By: beanz, abrachet, steven_wu

Differential Revision: https://reviews.llvm.org/D127318




More information about the All-commits mailing list