[all-commits] [llvm/llvm-project] 8a0cd2: Revert "[MemDep][NFCI] Remove redundant dyn_cast, ...

[Philip Reames via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8a0cd23326050a7b999efa2cf455880772ce9211
      https://github.com/llvm/llvm-project/commit/8a0cd23326050a7b999efa2cf455880772ce9211
  Author: Philip Reames <preames at rivosinc.com>
  Date:   2022-06-07 (Tue, 07 Jun 2022)

  Changed paths:
    M llvm/lib/Analysis/MemoryDependenceAnalysis.cpp

  Log Message:
  -----------
  Revert "[MemDep][NFCI] Remove redundant dyn_cast, replace with cast"

This reverts commit 180d3f251d1ad5473705d3f00e6d426b5f8162e6.  This commit is simply wrong.  IsLoad is set within the same file based on modref state, not whether the instruction is a LoadInst.

This went uncaught because cast<Ty>(X) has been broken.  See https://discourse.llvm.org/t/cast-x-is-broken-implications-and-proposal-to-address/63033 for context.