[all-commits] [llvm/llvm-project] 570e76: [config] Remove vestigial LLVM_VERSION_INFO
Reid Kleckner via All-commits
all-commits at lists.llvm.org
Tue Jun 7 11:48:30 PDT 2022
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 570e76bb6c79bce0718aa55915a4361e361b954f
https://github.com/llvm/llvm-project/commit/570e76bb6c79bce0718aa55915a4361e361b954f
Author: Reid Kleckner <rnk at google.com>
Date: 2022-06-07 (Tue, 07 Jun 2022)
Changed paths:
M llvm/include/llvm/Config/config.h.cmake
M llvm/lib/LTO/LTOCodeGenerator.cpp
M llvm/lib/Support/CommandLine.cpp
M llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
M utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
M utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h
M utils/bazel/llvm_configs/config.h.cmake
Log Message:
-----------
[config] Remove vestigial LLVM_VERSION_INFO
This has been superseded by the llvm/Support/VCSRevision.h header. So
far as I can tell, nothing in the CMake build sets LLVM_VERSION_INFO. It
was always undefined, and the ifdefs using it were dead. However, CMake
is very flexible, so it's possible that I missed some ways to set this
variable. One could, for example, probably pass -DLLVM_VERSION_INFO=x on
the command line and get that through to configure_file, or set the
variable in an obscure way (`set(${proj}_VERSION_INFO "x")`). I'm
reasonably confident that isn't happening, but I'd like a second
opinion.
Update the Bazel and gn builds accordingly.
Differential Revision: https://reviews.llvm.org/D126977
More information about the All-commits
mailing list