[all-commits] [llvm/llvm-project] ae38e4: [llvm-ml] Remove all file extension restrictions

Alan Zhao via All-commits all-commits at lists.llvm.org
Tue Jun 7 10:03:34 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ae38e4880ec06bf4cfb7088fa66f70676701144c
      https://github.com/llvm/llvm-project/commit/ae38e4880ec06bf4cfb7088fa66f70676701144c
  Author: Alan Zhao <ayzhao at google.com>
  Date:   2022-06-07 (Tue, 07 Jun 2022)

  Changed paths:
    M llvm/test/tools/llvm-ml/basic.test
    R llvm/test/tools/llvm-ml/invalid_file_extension.blah
    M llvm/test/tools/llvm-ml/lit.local.cfg
    A llvm/test/tools/llvm-ml/random_file_extension.blah
    R llvm/test/tools/llvm-ml/valid_file_extension.S
    M llvm/tools/llvm-ml/Opts.td
    M llvm/tools/llvm-ml/llvm-ml.cpp

  Log Message:
  -----------
  [llvm-ml] Remove all file extension restrictions

After D126425 was submitted, hans@ observed that MSVC's ml.exe doesn't
care about the file's extension at all. Now, we check if the file exists
to determine whether an input filename is a valid assembly file.

To keep things consistent with clang-cl and lld-link, llvm-ml will treat
everything that's not a flag as a filename.

Reviewed By: hans

Differential Revision: https://reviews.llvm.org/D126931




More information about the All-commits mailing list