[all-commits] [llvm/llvm-project] bf352e: [mlir:PDLL] Add better support for providing Const...

[River Riddle via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bf352e0b2ef9f8824a5b88d44313b5a13258350d
      https://github.com/llvm/llvm-project/commit/bf352e0b2ef9f8824a5b88d44313b5a13258350d
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-06-02 (Thu, 02 Jun 2022)

  Changed paths:
    M mlir/include/mlir/TableGen/Attribute.h
    M mlir/include/mlir/TableGen/Constraint.h
    M mlir/include/mlir/TableGen/Type.h
    M mlir/include/mlir/Tools/PDLL/AST/Nodes.h
    M mlir/include/mlir/Tools/PDLL/Parser/Parser.h
    M mlir/lib/TableGen/Attribute.cpp
    M mlir/lib/TableGen/Constraint.cpp
    M mlir/lib/TableGen/Type.cpp
    M mlir/lib/Tools/PDLL/AST/Nodes.cpp
    M mlir/lib/Tools/PDLL/ODS/Operation.cpp
    M mlir/lib/Tools/PDLL/Parser/Parser.cpp
    M mlir/lib/Tools/mlir-pdll-lsp-server/PDLLServer.cpp
    M mlir/test/mlir-pdll-lsp-server/hover.test
    M mlir/tools/mlir-pdll/mlir-pdll.cpp

  Log Message:
  -----------
  [mlir:PDLL] Add better support for providing Constraint/Pattern/Rewrite documentation

This commit enables providing long-form documentation more seamlessly to the LSP
by revamping decl documentation. For ODS imported constructs, we now also import
descriptions and attach them to decls when possible. For PDLL constructs, the LSP will
now try to provide documentation by parsing the comments directly above the decls
location within the source file. This commit also adds a new parser flag
`enableDocumentation` that gates the import and attachment of ODS documentation,
which is unnecessary in the normal build process (i.e. it should only be used/consumed
by tools).

Differential Revision: https://reviews.llvm.org/D124881