[all-commits] [llvm/llvm-project] 5a6352: Tidy up `pragma comment lib` handling and testing

Paul T Robinson via All-commits all-commits at lists.llvm.org
Thu Jun 2 07:52:45 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5a6352bc70fb0f309de22ea75ef132f32d8be9b4
      https://github.com/llvm/llvm-project/commit/5a6352bc70fb0f309de22ea75ef132f32d8be9b4
  Author: Paul Robinson <paul.robinson at sony.com>
  Date:   2022-06-02 (Thu, 02 Jun 2022)

  Changed paths:
    M clang/lib/Parse/ParsePragma.cpp
    M clang/test/CodeGen/pragma-comment.c
    A clang/test/Preprocessor/pragma-comment-elf.c
    R clang/test/Preprocessor/pragma-comment-linux.c
    R clang/test/Preprocessor/pragma_ps4.c

  Log Message:
  -----------
  Tidy up `pragma comment lib` handling and testing

A bit of historical research shows that over the years:
Commit 99efc036 added `pragma comment lib` support for PS4.
Commit fd4db533 added `pragma comment lib` support for all ELF targets.
Commit 1d16515f reworked dependent-library support for all ELF targets.

The upshot is that some PS4-specific code became dead, and the
testing became somewhat fragmented.  I've removed the dead code and
combined the previous PS4-specific and linux-specific tests for the
diagnostics into one generic ELF test.
Also added a couple of PS5 runs while I was in there.




More information about the All-commits mailing list