[all-commits] [llvm/llvm-project] 128ffb: Revert "[Driver][Modules] Remove dependence on lin...

Adrian Prantl via All-commits all-commits at lists.llvm.org
Wed Jun 1 12:12:12 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 128ffb332bca2c3efae82665b2b557f9b481b83f
      https://github.com/llvm/llvm-project/commit/128ffb332bca2c3efae82665b2b557f9b481b83f
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2022-06-01 (Wed, 01 Jun 2022)

  Changed paths:
    M clang/test/Driver/modules.cpp

  Log Message:
  -----------
  Revert "[Driver][Modules] Remove dependence on linking support from clang/test/Driver/modules.cpp"

This reverts commit 35b1cfc76f08faabf3f27c0bd054acc7c854a6ca as a dependency of D120540.


  Commit: c84b9bbac1ecaafb34daa7618b035f063ef1094e
      https://github.com/llvm/llvm-project/commit/c84b9bbac1ecaafb34daa7618b035f063ef1094e
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2022-06-01 (Wed, 01 Jun 2022)

  Changed paths:
    M clang/test/Driver/modules.cpp

  Log Message:
  -----------
  Revert "[NFC] Use %clang instead of %clang++ in tests"

This reverts commit 738c20e6df01217b6364c3b75d0ced6b6fb6277e as a dependency of D120540.


  Commit: d951ca5439bb8726cfe1ceb2d12e220f29fe5125
      https://github.com/llvm/llvm-project/commit/d951ca5439bb8726cfe1ceb2d12e220f29fe5125
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2022-06-01 (Wed, 01 Jun 2022)

  Changed paths:
    M clang-tools-extra/test/pp-trace/pp-trace-modules.cpp
    M clang/include/clang/Driver/Options.td
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/test/Driver/modules.cpp
    R clang/test/Modules/cxx-modules.cppm

  Log Message:
  -----------
  Revert "[Driver] Enable to use C++20 standalne by -fcxx-modules"

This reverts commit a544710cd43ba9f7729a613c58729f146e792a8e.

See discussion in D120540.

This breaks C++ Clang modules on Darwin and also more than a dozen
tests in the LLDB testsuite.  I think we need to be more careful to
separate out the enabling of Clang C++ modules and C++20
modules. Either by having -fmodules-ts control the HaveModules flag,
or by adding a way to explicitly turn them off.


Compare: https://github.com/llvm/llvm-project/compare/10c4eec2785a...d951ca5439bb


More information about the All-commits mailing list