[all-commits] [llvm/llvm-project] d15701: [VPlan] Remove unused native utilities incompatibl...

Florian Hahn via All-commits all-commits at lists.llvm.org
Wed Jun 1 01:33:35 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d157019482e19b33b4348f315692385c0ace4a61
      https://github.com/llvm/llvm-project/commit/d157019482e19b33b4348f315692385c0ace4a61
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2022-06-01 (Wed, 01 Jun 2022)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/CMakeLists.txt
    M llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp
    M llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
    M llvm/lib/Transforms/Vectorize/VPlan.h
    M llvm/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp
    R llvm/lib/Transforms/Vectorize/VPlanLoopInfo.h
    R llvm/lib/Transforms/Vectorize/VPlanPredicator.cpp
    R llvm/lib/Transforms/Vectorize/VPlanPredicator.h
    M llvm/unittests/Transforms/Vectorize/CMakeLists.txt
    R llvm/unittests/Transforms/Vectorize/VPlanDominatorTreeTest.cpp
    R llvm/unittests/Transforms/Vectorize/VPlanLoopInfoTest.cpp
    R llvm/unittests/Transforms/Vectorize/VPlanPredicatorTest.cpp
    M llvm/unittests/Transforms/Vectorize/VPlanTest.cpp

  Log Message:
  -----------
  [VPlan] Remove unused native utilities incompatible with nested regions.

The implementations of VPlanDominatorTree, VPlanLoopInfo and VPlanPredicator
are all incompatible with modeling loops in VPlans as region without
explicit back-edges.

Those pieces are not actively used and only exercised by a few gtest
unit tests. They are at the moment blocking progress towards unifying
the native and inner-loop vectorizer paths in D121624 and D123005.

I think we should not block forward progress on unused pieces of code,
so this patch removes the utilities for now. The plan is to re-introduce
them as needed in a way that is compatible with the unified VPlan scheme
used in both the inner loop vectorizer and the native path.

Reviewed By: sguggill

Differential Revision: https://reviews.llvm.org/D123017




More information about the All-commits mailing list