[all-commits] [llvm/llvm-project] 80b3dc: [Support] Make report_fatal_error respect its GenC...

[Nuno Lopes via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 80b3dcc045f8ea6e5e532d8891bbf1305bce89e8
      https://github.com/llvm/llvm-project/commit/80b3dcc045f8ea6e5e532d8891bbf1305bce89e8
  Author: Nuno Lopes <nuno.lopes at tecnico.ulisboa.pt>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M llvm/lib/Support/ErrorHandling.cpp
    M llvm/lib/Target/Mips/MipsSubtarget.cpp
    M llvm/lib/Transforms/IPO/BlockExtractor.cpp
    M llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp
    M llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp
    M llvm/test/CodeGen/ARM/codemodel.ll
    M llvm/test/CodeGen/BPF/xadd.ll
    M llvm/test/CodeGen/Lanai/codemodel.ll
    M llvm/test/CodeGen/Mips/cpus.ll
    M llvm/test/CodeGen/Mips/fp64a.ll
    M llvm/test/CodeGen/Mips/fpxx.ll
    M llvm/test/CodeGen/Mips/micromips64-unsupported.ll
    M llvm/test/CodeGen/Mips/mips32r6/compatibility.ll
    M llvm/test/CodeGen/Mips/mips64r6/compatibility.ll
    M llvm/test/CodeGen/Mips/msa/3r-a.ll
    M llvm/test/CodeGen/PowerPC/codemodel.ll
    M llvm/test/CodeGen/SPARC/codemodel.ll
    M llvm/test/CodeGen/SystemZ/codemodel.ll
    M llvm/test/CodeGen/WebAssembly/tls-general-dynamic.ll
    M llvm/test/CodeGen/X86/codemodel.ll
    M llvm/test/MC/Mips/micromips64-unsupported.s
    M llvm/test/MC/Mips/micromips64r6-unsupported.s
    M llvm/test/Other/optimization-remarks-inline.ll
    M llvm/test/Transforms/BlockExtractor/invalid-block.ll
    M llvm/test/Transforms/BlockExtractor/invalid-function.ll
    M llvm/test/Transforms/BlockExtractor/invalid-line.ll
    M llvm/test/Transforms/GCOVProfiling/version.ll
    M llvm/test/Transforms/LoopUnroll/peel-loop-and-unroll.ll

  Log Message:
  -----------
  [Support] Make report_fatal_error respect its GenCrashDiag argument so it doesn't generate a backtrace

There are a few places where we use report_fatal_error when the input is broken.
Currently, this function always crashes LLVM with an abort signal, which
then triggers the backtrace printing code.
I think this is excessive, as wrong input shouldn't give a link to
LLVM's github issue URL and tell users to file a bug report.
We shouldn't print a stack trace either.

This patch changes report_fatal_error so it uses exit() rather than
abort() when its argument GenCrashDiag=false.

Reviewed by: nikic, MaskRay, RKSimon

Differential Revision: https://reviews.llvm.org/D126550