[all-commits] [llvm/llvm-project] f3defc: [ODRHash][NFC] Add missing 'select' case for `ODRM...

Volodymyr Sapsai via All-commits all-commits at lists.llvm.org
Mon May 30 10:07:31 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f3defc23488eb29c69d2a33c0c5b652c874fb0f3
      https://github.com/llvm/llvm-project/commit/f3defc23488eb29c69d2a33c0c5b652c874fb0f3
  Author: Volodymyr Sapsai <vsapsai at apple.com>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSerializationKinds.td

  Log Message:
  -----------
  [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`.

No test changes because `err_module_odr_violation_mismatch_decl_unknown`
is a catch-all when custom diagnostic is missing. And missing custom
diagnostic we should fix by implementing it, not by improving the
general case. But if we pass enum value not covered by 'select', clang
can crash, so protect against that.

Differential Revision: https://reviews.llvm.org/D126566




More information about the All-commits mailing list