[all-commits] [llvm/llvm-project] 919107: [lldb] Fix cross compiling on macOS

Martin Storsjö via All-commits all-commits at lists.llvm.org
Fri May 27 14:53:50 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9191078707390c32b691ff84633ab9450b380ea5
      https://github.com/llvm/llvm-project/commit/9191078707390c32b691ff84633ab9450b380ea5
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-05-28 (Sat, 28 May 2022)

  Changed paths:
    M lldb/test/CMakeLists.txt

  Log Message:
  -----------
  [lldb] Fix cross compiling on macOS

When cross compiling, a separate nested cmake is spawned, for building
host code generation tools such as lldb-tblgen.

When cross compiling on macOS, the nested native build would trigger
the lldb check for libc++, if testing is enabled (which it is by default).
(Even if `LLDB_INCLUDE_TESTS=OFF` is set on the main build, it has to
be passed separately in `CROSS_TOOLCHAIN_FLAGS_NATIVE` to reach the
nested build.)

Skip this check when building the host tools when cross compiling, as
the user won't try to run tests in that nested build.

(Alternatively, we could consider disabling all the `*_INCLUDE_TESTS`
by default in the nested host tools build.)

Differential Revision: https://reviews.llvm.org/D126557




More information about the All-commits mailing list