[all-commits] [llvm/llvm-project] 8e724a: [TSan][Darwin] Deflake test

Julian Lettner via All-commits all-commits at lists.llvm.org
Fri May 27 10:20:11 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8e724ad96565de7f91d7d9f89c24d0086086a903
      https://github.com/llvm/llvm-project/commit/8e724ad96565de7f91d7d9f89c24d0086086a903
  Author: Julian Lettner <julian.lettner at apple.com>
  Date:   2022-05-27 (Fri, 27 May 2022)

  Changed paths:
    M compiler-rt/test/tsan/Darwin/dyld-insert-libraries.c

  Log Message:
  -----------
  [TSan][Darwin] Deflake test

The asserted order of THREAD_DESTROY and end of main() is not
guaranteed:
```
 7: Hello from pthread
 8: THREAD_TERMINATE 0x7e8000104000, self: 0x7e8000104000, name: child thread
 9: Done.
10: THREAD_DESTROY 0x7e8000104000, self: 0x7e8000104000, name: child thread
```

Resulting in:
```
error: CHECK: expected string not found in input
// CHECK: Done.
```

Remove checking for "Done." (end of main()) to deflake this test.
Alternatively, we could use `CHECK-DAG`.

rdar://94036145




More information about the All-commits mailing list