[all-commits] [llvm/llvm-project] 67136d: [clang][dataflow] Remove private-field filtering f...

[Yitzhak Mandelbaum via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 67136d0e8fb57251dece4be0907414fdbe081f7a
      https://github.com/llvm/llvm-project/commit/67136d0e8fb57251dece4be0907414fdbe081f7a
  Author: Yitzhak Mandelbaum <yitzhakm at google.com>
  Date:   2022-05-27 (Fri, 27 May 2022)

  Changed paths:
    M clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
    M clang/unittests/Analysis/FlowSensitive/TransferTest.cpp

  Log Message:
  -----------
  [clang][dataflow] Remove private-field filtering from `StorageLocation` creation.

The API for `AggregateStorageLocation` does not allow for missing fields (it asserts). Therefore, it is incorrect to filter out any fields at location-creation time which may be accessed by the code. Currently, we limit filtering to private, base-calss fields on the assumption that those can never be accessed. However, `friend` declarations can invalidate that assumption, thereby breaking our invariants.

This patch removes said field filtering to avoid violating the invariant of "no missing fields" for `AggregateStorageLocation`.

Differential Revision: https://reviews.llvm.org/D126420