[all-commits] [llvm/llvm-project] 2046e1: [mlir][sparse] Improving ExecutionEngine/SparseTen...

[wren romano via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2046e11ac493818ef782d71a841275c10f3834c5
      https://github.com/llvm/llvm-project/commit/2046e11ac493818ef782d71a841275c10f3834c5
  Author: wren romano <2998727+wrengr at users.noreply.github.com>
  Date:   2022-05-26 (Thu, 26 May 2022)

  Changed paths:
    M mlir/include/mlir/ExecutionEngine/SparseTensorUtils.h
    M mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
    M utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  Log Message:
  -----------
  [mlir][sparse] Improving ExecutionEngine/SparseTensorUtils.h

This change makes the public API of SparseTensorUtils.cpp explicit, whereas before the publicity of these functions was only implicit.  Implicit publicity is sufficient for mlir-opt to generate calls to these functions, but it's not enough to enable C/C++ code to call them directly in the usual way (i.e., without going through codegen).  Thus, leaving the publicity implicit prevents development of other tools (e.g., microbenchmarks).

In addition this change also marks the functions MLIR_CRUNNERUTILS_EXPORT, which is required by the JIT under certain configurations (albeit not for anything in our test suite).

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D126105