[all-commits] [llvm/llvm-project] 7f5439: [compiler-rt][test] Fix flake in symbolize_stack test

Paul Kirth via All-commits all-commits at lists.llvm.org
Wed May 25 12:02:45 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7f5439945b1f07535ea667ec31a82a9d9a2a8666
      https://github.com/llvm/llvm-project/commit/7f5439945b1f07535ea667ec31a82a9d9a2a8666
  Author: Paul Kirth <paulkirth at google.com>
  Date:   2022-05-25 (Wed, 25 May 2022)

  Changed paths:
    M compiler-rt/test/sanitizer_common/TestCases/symbolize_stack.cpp

  Log Message:
  -----------
  [compiler-rt][test] Fix flake in symbolize_stack test

Addresses tests flakes described in
https://github.com/llvm/llvm-project/issues/55460

The test being updated can fail in FileCheck to match when given long
enough stack traces. This can be problematic when file system paths
become long enough to cause the majority of the long function name to
become truncated. We found in our CI that the truncated output would
often fail to match, thereby causing the test to fail when it should not.

Here we change the test to match on sybolizer output that should be more
reliable than matching inside the long function name.

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D126102




More information about the All-commits mailing list