[all-commits] [llvm/llvm-project] 0c8fdd: [mlir] Fix Tensor_InsertSliceOp description

Logan Chien via All-commits all-commits at lists.llvm.org
Wed May 25 09:39:25 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c8fdd72309e7b6f542acd8213a23917e0fd2e9e
      https://github.com/llvm/llvm-project/commit/0c8fdd72309e7b6f542acd8213a23917e0fd2e9e
  Author: Logan Chien <tzuhsiang.chien at gmail.com>
  Date:   2022-05-25 (Wed, 25 May 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/Tensor/IR/TensorOps.td

  Log Message:
  -----------
  [mlir] Fix Tensor_InsertSliceOp description

This commit fixes `Tensor_InsertSliceOp` `sizes` inputs/attributes
description.

Before this commit, the description says the `sizes` inputs/attributes
denote the size of the return type. But according to the
`InsertSliceOpConstantArgumentFolder` in
`lib/Dialect/Tensor/IR/TensorOps.cpp`, the `sizes` inputs/attributes
actually denote the size of the source type.

I had an off-line discussion with the authors of `TensorOps.td` and
`TensorOps.cpp`. We concluded that it was a typo in the Op description.

This commit updates the Op description to match the actual usage.

Differential Revision: https://reviews.llvm.org/D126264




More information about the All-commits mailing list