[all-commits] [llvm/llvm-project] 0a7911: [flang] Replace crash and improve a semantics TODO...

[Peter Klausler via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0a79113b9e064e50f660ebe6e257bf69ba028026
      https://github.com/llvm/llvm-project/commit/0a79113b9e064e50f660ebe6e257bf69ba028026
  Author: Peter Klausler <pklausler at nvidia.com>
  Date:   2022-05-24 (Tue, 24 May 2022)

  Changed paths:
    M flang/lib/Semantics/runtime-type-info.cpp

  Log Message:
  -----------
  [flang] Replace crash and improve a semantics TODO message

The derived type information table construction code had a
crash whose root cause was replacing an expression with one
of its operands -- the deletion of the LHS of that assignment
led to the RHS being invalidated before it could be read.
Fix by cloning the RHS.  Also update a TODO message to the
new "_todo_en_US" message class and add a comment about how
it should be resolved.

Differential Revision: https://reviews.llvm.org/D126154