[all-commits] [llvm/llvm-project] c11051: [SelectionDAG] Add a freeze to ISD::ABS expansion.
Craig Topper via All-commits
all-commits at lists.llvm.org
Sun May 22 14:30:29 PDT 2022
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: c11051a4001c7f89e8655f1776a75110a562a45e
https://github.com/llvm/llvm-project/commit/c11051a4001c7f89e8655f1776a75110a562a45e
Author: Craig Topper <craig.topper at sifive.com>
Date: 2022-05-22 (Sun, 22 May 2022)
Changed paths:
M llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
M llvm/test/CodeGen/WebAssembly/PR41149.ll
M llvm/test/CodeGen/X86/iabs.ll
M llvm/test/CodeGen/X86/neg-abs.ll
M llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/basic.ll.expected
Log Message:
-----------
[SelectionDAG] Add a freeze to ISD::ABS expansion.
I had initially assumed this was the problem with
https://github.com/llvm/llvm-project/issues/55271#issuecomment-1133426243
But it turns out that was a simpler issue. This patch is still
more correct than what we were doing before so figured I'd submit
it anyway.
No test case because I'm not sure how to get an undef around
until expansion.
Looking at the test deltas I wonder if it be valid to combine
(sext_inreg (freeze (aextload X))) -> (freeze (sextload X)).
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D126175
More information about the All-commits
mailing list