[all-commits] [llvm/llvm-project] d252d9: [lldb] Fix spurious assertion in PrintCommandOutput

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Fri May 20 14:15:54 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d252d9231c4a5008a69c6791db498aaf95bda8e7
      https://github.com/llvm/llvm-project/commit/d252d9231c4a5008a69c6791db498aaf95bda8e7
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2022-05-20 (Fri, 20 May 2022)

  Changed paths:
    M lldb/source/Interpreter/CommandInterpreter.cpp

  Log Message:
  -----------
  [lldb] Fix spurious assertion in PrintCommandOutput

When the string passed to PrintCommandOutput doesn't end with a newline,
`written` will exceed `size` and result in an lldbassert.

After 8e776bb660dda6c51ce7ca6cea641db1f47aa9cf we don't really need
written anymore and we can check whether `str` is empty instead. This
patch simplifies the code and removes the assert that's no longer
relevant.

Differential revision: https://reviews.llvm.org/D126081




More information about the All-commits mailing list