[all-commits] [llvm/llvm-project] 797fab: [Analysis] Avoid virtual dtor. NFC.

Michael Kruse via All-commits all-commits at lists.llvm.org
Wed May 18 15:43:26 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 797fabaab2a5e02d00de4755ef8f5a38127110df
      https://github.com/llvm/llvm-project/commit/797fabaab2a5e02d00de4755ef8f5a38127110df
  Author: Michael Kruse <llvm-project at meinersbur.de>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M llvm/include/llvm/Analysis/DOTGraphTraitsPass.h
    M llvm/include/llvm/Analysis/DomPrinter.h

  Log Message:
  -----------
  [Analysis] Avoid virtual dtor. NFC.

Replace virtual destructor by a protected non-virtual one. Additionally also making derived structs as virtual avoids the warning from reappearing.

Also see the mailing list discussion: https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20220516/1038290.html

Reviewed By: dblaikie, YangKeao

Differential Revision: https://reviews.llvm.org/D125830




More information about the All-commits mailing list