[all-commits] [llvm/llvm-project] 29e556: [lldb] Change implementation of memory read --show...

David Spickett via All-commits all-commits at lists.llvm.org
Wed May 18 08:49:24 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 29e556fc2ba93028f0dc45c4c2636da6283e9c28
      https://github.com/llvm/llvm-project/commit/29e556fc2ba93028f0dc45c4c2636da6283e9c28
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    A lldb/include/lldb/Interpreter/OptionGroupMemoryTag.h
    M lldb/source/Commands/CommandObjectMemory.cpp
    M lldb/source/Commands/Options.td
    M lldb/source/Interpreter/CMakeLists.txt
    A lldb/source/Interpreter/OptionGroupMemoryTag.cpp
    M lldb/test/API/commands/help/TestHelp.py
    M lldb/test/API/linux/aarch64/mte_tag_access/TestAArch64LinuxMTEMemoryTagAccess.py

  Log Message:
  -----------
  [lldb] Change implementation of memory read --show-tags option

This does 2 things:
* Moves it after the short options. Which makes sense given it's
  a niche, default off option.
  (if 2 files for one option seems a bit much, I am going to reuse
  them for "memory find" later)
* Fixes the use of repeated commands. For example:
    memory read buf --show-tags
    <shows tags>
    memory read
    <shows tags>

Added tests for the repetition and updated existing help tests.

Reviewed By: omjavaid

Differential Revision: https://reviews.llvm.org/D125089




More information about the All-commits mailing list