[all-commits] [llvm/llvm-project] 00a125: [lldb][AArch64] Fix corefile memory reads when the...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 00a12585933ef63ff1204bf5cd265f0071d04642
      https://github.com/llvm/llvm-project/commit/00a12585933ef63ff1204bf5cd265f0071d04642
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp
    M lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
    M lldb/test/API/linux/aarch64/non_address_bit_memory_access/TestAArch64LinuxNonAddressBitMemoryAccess.py
    A lldb/test/API/linux/aarch64/non_address_bit_memory_access/corefile
    M lldb/test/API/linux/aarch64/non_address_bit_memory_access/main.c

  Log Message:
  -----------
  [lldb][AArch64] Fix corefile memory reads when there are non-address bits

Previously if you read a code/data mask before there was a valid thread
you would get the top byte mask. This meant the value was "valid" as in,
don't read it again.

When using a corefile we ask for the data mask very early on and this
meant that later once you did have a thread it wouldn't read the
register to get the rest of the mask.

This fixes that and adds a corefile test generated from the same program
as in my previous change on this theme.

Depends on D118794

Reviewed By: omjavaid

Differential Revision: https://reviews.llvm.org/D122411