[all-commits] [llvm/llvm-project] 7814b5: [GreedyPatternRewriter] Avoid reversing constant o...

rk via All-commits all-commits at lists.llvm.org
Wed May 18 00:56:25 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7814b559bd5e1dbb3c016b393068698bc5781cc5
      https://github.com/llvm/llvm-project/commit/7814b559bd5e1dbb3c016b393068698bc5781cc5
  Author: rkayaith <rkayaith at gmail.com>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M flang/test/Lower/Intrinsics/achar.f90
    M mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
    M mlir/test/Dialect/Arithmetic/canonicalize.mlir
    M mlir/test/Dialect/SCF/canonicalize.mlir
    M mlir/test/Transforms/test-operation-folder.mlir
    M mlir/test/lib/Dialect/Test/TestPatterns.cpp

  Log Message:
  -----------
  [GreedyPatternRewriter] Avoid reversing constant order

The previous fix from af371f9f98da only applied when using a bottom-up
traversal. The change here applies the constant preprocessing logic to the
top-down case as well. This resolves the issue with the canonicalizer pass still
reordering constants, since it uses a top-down traversal by default.

Fixes #51892

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D125623




More information about the All-commits mailing list