[all-commits] [llvm/llvm-project] 862b5a: [MLIR][Presburger] Attach values only to non-local...

[Kunwar Shaanjeet Singh Grover via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 862b5a52335fef9e29013b00506e49342ac473f1
      https://github.com/llvm/llvm-project/commit/862b5a52335fef9e29013b00506e49342ac473f1
  Author: Groverkss <groverkss at gmail.com>
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/Affine/Analysis/AffineStructures.h
    M mlir/lib/Dialect/Affine/Analysis/AffineStructures.cpp

  Log Message:
  -----------
  [MLIR][Presburger] Attach values only to non-local identifiers in FAVC

This patch changes `FlatAffineValueConstraints` to only allow attaching
values to non-local identifiers.

The reasoning for this change is:
1. Information attached to local identifiers can be lost since local identifiers
  can be removed for output size optimizations.
2. There are no current use cases for attaching values to Local identifiers.
3. Attaching a value to a local identifier does not make sense since a local
  identifier represents existential quantification.

This patch also adds some additional asserts to the affected functions.

Reviewed By: arjunp, bondhugula

Differential Revision: https://reviews.llvm.org/D125613