[all-commits] [llvm/llvm-project] 599ff2: [StackColoring] Don't merge slots with differing S...

[Fraser Cormack via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 599ff247dee8f462638731c3b2fdd3d1e332a2fe
      https://github.com/llvm/llvm-project/commit/599ff247dee8f462638731c3b2fdd3d1e332a2fe
  Author: Fraser Cormack <fraser at codeplay.com>
  Date:   2022-05-17 (Tue, 17 May 2022)

  Changed paths:
    M llvm/lib/CodeGen/StackColoring.cpp
    A llvm/test/CodeGen/RISCV/rvv/stack-coloring-scalablevec.mir

  Log Message:
  -----------
  [StackColoring] Don't merge slots with differing StackIDs

The documentation for this specifically mentions that this should not
happen. We could think about adding target hooks to permit it (and how
to merge IDs) in the future if that is desirable.

This specific test case was merging a scalable-vector slot into a
non-scalable one and dropping the notion of scalability, meaning we
failed to allocate enough stack space for the object.

Reviewed By: arsenm, MaskRay, sdesmalen

Differential Revision: https://reviews.llvm.org/D125699