[all-commits] [llvm/llvm-project] 96c2a0: [GlobalIsel] Fix fallback if stack protector isn't...

Eli Friedman via All-commits all-commits at lists.llvm.org
Fri May 13 14:18:06 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 96c2a0c9fff24803be14bfaa579e4f230763d3cc
      https://github.com/llvm/llvm-project/commit/96c2a0c9fff24803be14bfaa579e4f230763d3cc
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2022-05-13 (Fri, 13 May 2022)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
    A llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-stack-protector-windows.ll

  Log Message:
  -----------
  [GlobalIsel] Fix fallback if stack protector isn't supported.

When GlobalISel fails, we need to report the error, and we need to set
the FailedISel property.  We skipped those steps if stack protector
insertion failed, which led to a very strange miscompile.

Differential Revision: https://reviews.llvm.org/D125584




More information about the All-commits mailing list