[all-commits] [llvm/llvm-project] 00a3c9: [Frontend] Flip default of CreateInvocationOptions...

[Sam McCall via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 00a3c9f2a46a566b3ff10f2d24b01426df2193ab
      https://github.com/llvm/llvm-project/commit/00a3c9f2a46a566b3ff10f2d24b01426df2193ab
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2022-05-10 (Tue, 10 May 2022)

  Changed paths:
    M clang/include/clang/Frontend/Utils.h
    M clang/lib/Frontend/ASTUnit.cpp
    M clang/tools/c-index-test/core_main.cpp
    M clang/tools/libclang/Indexing.cpp
    M clang/unittests/Frontend/UtilsTest.cpp

  Log Message:
  -----------
  [Frontend] Flip default of CreateInvocationOptions::ProbePrecompiled to false

This is generally a better default for tools other than the compiler, which
shouldn't assume a PCH file on disk is something they can consume.

Preserve the old behavior in places associated with libclang/c-index-test
(including ASTUnit) as there are tests relying on it and most important
consumers are out-of-tree. It's unclear whether the tests are specifically
trying to test this functionality, and what the downstream implications of
removing it are. Hopefully someone more familiar can clean this up in future.

Differential Revision: https://reviews.llvm.org/D125149