[all-commits] [llvm/llvm-project] bb53eb: [clangd] Skip extra round-trip in parsing args in ...

Sam McCall via All-commits all-commits at lists.llvm.org
Mon May 9 05:46:39 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bb53eb1ef4369fa7ae13d693eb219665c2cecd24
      https://github.com/llvm/llvm-project/commit/bb53eb1ef4369fa7ae13d693eb219665c2cecd24
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2022-05-09 (Mon, 09 May 2022)

  Changed paths:
    M clang-tools-extra/clangd/Compiler.cpp

  Log Message:
  -----------
  [clangd] Skip extra round-trip in parsing args in debug builds. NFC

This is a clever cross-cutting sanity test for clang's arg parsing I suppose.
But clangd creates thousands of invocations, ~all with identical trivial
arguments, and problems with these would be caught by clang's tests.
This overhead accounts for 10% of total unittest time!

Differential Revision: https://reviews.llvm.org/D125169




More information about the All-commits mailing list