[all-commits] [llvm/llvm-project] 12cb54: [clang-tidy][NFC] Replace many instances of std::s...

[Nathan James via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 12cb540529e41d12cf27d2e716a384b6692563a8
      https://github.com/llvm/llvm-project/commit/12cb540529e41d12cf27d2e716a384b6692563a8
  Author: Nathan James <n.james93 at hotmail.co.uk>
  Date:   2022-05-09 (Mon, 09 May 2022)

  Changed paths:
    M clang-tools-extra/clang-tidy/ClangTidyCheck.cpp
    M clang-tools-extra/clang-tidy/ClangTidyCheck.h
    M clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp
    M clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.h
    M clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp
    M clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.h
    M clang-tools-extra/clang-tidy/android/ComparisonInTempFailureRetryCheck.h
    M clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp
    M clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.h
    M clang-tools-extra/clang-tidy/bugprone/DanglingHandleCheck.cpp
    M clang-tools-extra/clang-tidy/bugprone/DanglingHandleCheck.h
    M clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.h
    M clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp
    M clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.h
    M clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp
    M clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.h
    M clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp
    M clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.h
    M clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp
    M clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.h
    M clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.h
    M clang-tools-extra/clang-tidy/bugprone/SuspiciousMissingCommaCheck.cpp
    M clang-tools-extra/clang-tidy/bugprone/SuspiciousStringCompareCheck.cpp
    M clang-tools-extra/clang-tidy/bugprone/SuspiciousStringCompareCheck.h
    M clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
    M clang-tools-extra/clang-tidy/cert/NonTrivialTypesLibcMemoryCallsCheck.cpp
    M clang-tools-extra/clang-tidy/cert/NonTrivialTypesLibcMemoryCallsCheck.h
    M clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.h
    M clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp
    M clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.h
    M clang-tools-extra/clang-tidy/cppcoreguidelines/NoMallocCheck.cpp
    M clang-tools-extra/clang-tidy/cppcoreguidelines/NoMallocCheck.h
    M clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp
    M clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.h
    M clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h
    M clang-tools-extra/clang-tidy/google/GlobalNamesInHeadersCheck.h
    M clang-tools-extra/clang-tidy/google/IntegerTypesCheck.h
    M clang-tools-extra/clang-tidy/google/UnnamedNamespaceInHeaderCheck.h
    M clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.h
    M clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.h
    M clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.h
    M clang-tools-extra/clang-tidy/modernize/ReplaceDisallowCopyAndAssignMacroCheck.h
    M clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp
    M clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.h
    M clang-tools-extra/clang-tidy/modernize/UseNodiscardCheck.cpp
    M clang-tools-extra/clang-tidy/modernize/UseNodiscardCheck.h
    M clang-tools-extra/clang-tidy/modernize/UseNoexceptCheck.cpp
    M clang-tools-extra/clang-tidy/modernize/UseNoexceptCheck.h
    M clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.h
    M clang-tools-extra/clang-tidy/modernize/UseOverrideCheck.cpp
    M clang-tools-extra/clang-tidy/modernize/UseOverrideCheck.h
    M clang-tools-extra/clang-tidy/objc/ForbiddenSubclassingCheck.cpp
    M clang-tools-extra/clang-tidy/objc/ForbiddenSubclassingCheck.h
    M clang-tools-extra/clang-tidy/performance/FasterStringFindCheck.cpp
    M clang-tools-extra/clang-tidy/performance/FasterStringFindCheck.h
    M clang-tools-extra/clang-tidy/performance/ForRangeCopyCheck.h
    M clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp
    M clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.h
    M clang-tools-extra/clang-tidy/performance/NoAutomaticMoveCheck.h
    M clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp
    M clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.h
    M clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.h
    M clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
    M clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h
    M clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp
    M clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.h
    M clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp
    M clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.h
    M clang-tools-extra/clang-tidy/readability/SimplifySubscriptExprCheck.cpp
    M clang-tools-extra/clang-tidy/readability/SimplifySubscriptExprCheck.h
    M clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp
    M clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp
    M clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.h
    M clang-tools-extra/clang-tidy/utils/Matchers.h
    M clang-tools-extra/clang-tidy/utils/OptionsUtils.cpp
    M clang-tools-extra/clang-tidy/utils/OptionsUtils.h
    M clang-tools-extra/clang-tidy/zircon/TemporaryObjectsCheck.cpp
    M clang-tools-extra/clang-tidy/zircon/TemporaryObjectsCheck.h

  Log Message:
  -----------
  [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

There's many instances in clang tidy checks where owning strings are used when we already have a stable string from the options, so using a StringRef makes much more sense.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D124341