[all-commits] [llvm/llvm-project] 00bfab: [LegalizeTypes] Don't assume fshl/fshr shift amoun...

Craig Topper via All-commits all-commits at lists.llvm.org
Sat May 7 11:52:27 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 00bfaba997e944be7edb52fb3933a19178ec239d
      https://github.com/llvm/llvm-project/commit/00bfaba997e944be7edb52fb3933a19178ec239d
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2022-05-07 (Sat, 07 May 2022)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
    M llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h

  Log Message:
  -----------
  [LegalizeTypes] Don't assume fshl/fshr shift amount type matches the other operands.

Like other shifts, the type isn't required to match. We shouldn't
assume we can call ZExtPromotedInteger.

I tested the PromoteIntOp_FunnelShift locally by removing the promotion
of the shift amount from PromoteIntRes_FunnelShift. But with the final
version of this patch it is never executed on any tests.

Differential Revision: https://reviews.llvm.org/D125106




More information about the All-commits mailing list