[all-commits] [llvm/llvm-project] 7cc837: Generalize "check-all" umbrella targets, use for c...

Sam McCall via All-commits all-commits at lists.llvm.org
Fri May 6 03:31:09 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7cc8377f2c572a919ecb2d22b2039acf3e6b745a
      https://github.com/llvm/llvm-project/commit/7cc8377f2c572a919ecb2d22b2039acf3e6b745a
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2022-05-06 (Fri, 06 May 2022)

  Changed paths:
    M clang-tools-extra/CMakeLists.txt
    M clang-tools-extra/test/CMakeLists.txt
    M clang/CMakeLists.txt
    M clang/bindings/python/tests/CMakeLists.txt
    M clang/runtime/CMakeLists.txt
    M compiler-rt/test/CMakeLists.txt
    M llvm/CMakeLists.txt
    M llvm/cmake/modules/AddLLVM.cmake
    M llvm/runtimes/CMakeLists.txt
    M runtimes/CMakeLists.txt
    M runtimes/Tests.cmake.in

  Log Message:
  -----------
  Generalize "check-all" umbrella targets, use for check-clang-tools

The mechanism behind "check-all" is recording params of add_lit_testsuite()
calls in global variables LLVM_LIT_*, and then creating an extra suite with
their union at the end.
This avoids composing the check-* targets directly, which doesn't work well.

We generalize this by allowing multiple families of variables LLVM_{name}_LIT_*:
  umbrella_lit_testsuite_begin(check-foo)
  ... test suites here will be added to LLVM_FOO_LIT_* variables ...
  umbrella_lit_testsuite_end(check-foo)
(This also moves some implementation muck out of {llvm,clang}/CMakeLists.txt

This patch also changes check-clang-tools to use be an umbrella test target,
which means the clangd and clang-pseudo tests are included in it, along with the
the other testsuites that already are (like check-clang-extra-clang-tidy).

Differential Revision: https://reviews.llvm.org/D121838




More information about the All-commits mailing list