[all-commits] [llvm/llvm-project] a0fb38: [DebugInfo] Give warning instead of error for prem...

Junfeng Dong via All-commits all-commits at lists.llvm.org
Wed May 4 15:22:14 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a0fb387941cd26c9fbaa695dd7ddbfdc9a48eb46
  Author: Junfeng Dong <jfdong at fb.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFDebugAranges.h
    M llvm/lib/DebugInfo/DWARF/DWARFDebugAranges.cpp
    A llvm/test/tools/llvm-symbolizer/debug-aranges-premature-end.yaml

  Log Message:
  [DebugInfo] Give warning instead of error for premature terminator in .debug_aranges section.

llvm-profgen gives error message when the input binary contains premature terminator in .debug_aranges section. These zero length items point to some rodata with zero size type in embed Rust Library. Considering Zero-Sized Types are a valid feature in Rust. They are not real error. This change makes the "error:" message into a warning to avoid misleading.

Why do we still want a warning on such case? because it doesn't follow dwarf standard.  https://bugs.llvm.org/show_bug.cgi?id=46805 contains early discussion.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D124121

More information about the All-commits mailing list