[all-commits] [llvm/llvm-project] 68c729: [BOLT][NFC] Fix MCPlusBuilder::getAliases caching ...

Amir Ayupov via All-commits all-commits at lists.llvm.org
Wed May 4 12:53:41 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 68c7299f16aa6a6990f35a0d10d084b971a6f389
      https://github.com/llvm/llvm-project/commit/68c7299f16aa6a6990f35a0d10d084b971a6f389
  Author: Amir Ayupov <amir.aupov at gmail.com>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M bolt/include/bolt/Core/MCPlusBuilder.h
    M bolt/lib/Core/MCPlusBuilder.cpp

  Log Message:
  -----------
  [BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior

Caching behavior of `getAliases` causes a failure in unit tests where two
MCPlusBuilder objects are created corresponding to AArch64 and X86:
the alias cache is created for AArch64 but then used for X86.

https://lab.llvm.org/staging/#/builders/211/builds/126

The issue only affects unit tests as we only construct one MCPlusBuilder
for ELF binary.

Resolve the issue by moving alias bitvectors to MCPlusBuilder object.

Reviewed By: yota9

Differential Revision: https://reviews.llvm.org/D124942




More information about the All-commits mailing list