[all-commits] [llvm/llvm-project] 350bdf: [CMake] Make omitting CMAKE_BUILD_TYPE an error

[Tobias Hieta via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 350bdf9227cebceb7b7a283f90f504555bf6c496
      https://github.com/llvm/llvm-project/commit/350bdf9227cebceb7b7a283f90f504555bf6c496
  Author: Tobias Hieta <tobias at hieta.se>
  Date:   2022-05-04 (Wed, 04 May 2022)

  Changed paths:
    M llvm/CMakeLists.txt
    M llvm/docs/AdvancedBuilds.rst
    M llvm/docs/GettingStarted.rst
    M llvm/docs/HowToCrossCompileLLVM.rst
    M llvm/docs/ReleaseNotes.rst
    M llvm/docs/TestSuiteGuide.md

  Log Message:
  -----------
  [CMake] Make omitting CMAKE_BUILD_TYPE an error

After a lot of discussion in this diff the consensus was that it is really hard to guess the users intention with their LLVM build. Instead of trying to guess if Debug or Release is the correct default option we opted for just not specifying CMAKE_BUILD_TYPE a error.

Discussion on discourse here:
https://discourse.llvm.org/t/rfc-select-a-better-linker-by-default-or-warn-about-using-bfd

Reviewed By: hans, mehdi_amini, aaron.ballman, jhenderson, MaskRay, awarzynski

Differential Revision: https://reviews.llvm.org/D124153