[all-commits] [llvm/llvm-project] 2f9fc5: [lldb] Add setting for max depth of value object p...

Dave Lee via All-commits all-commits at lists.llvm.org
Tue May 3 10:39:58 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2f9fc576be206bd5c4fddfec5f89fceb3554a8d6
  Author: Dave Lee <davelee.com at gmail.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M lldb/include/lldb/DataFormatters/DumpValueObjectOptions.h
    M lldb/include/lldb/DataFormatters/ValueObjectPrinter.h
    M lldb/include/lldb/Interpreter/CommandInterpreter.h
    M lldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h
    M lldb/include/lldb/Interpreter/OptionValueProperties.h
    M lldb/include/lldb/Target/Target.h
    M lldb/source/Commands/CommandObjectFrame.cpp
    M lldb/source/Commands/CommandObjectTarget.cpp
    M lldb/source/DataFormatters/DumpValueObjectOptions.cpp
    M lldb/source/DataFormatters/ValueObjectPrinter.cpp
    M lldb/source/Interpreter/CommandInterpreter.cpp
    M lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp
    M lldb/source/Interpreter/OptionValueProperties.cpp
    M lldb/source/Target/Target.cpp
    M lldb/source/Target/TargetProperties.td

  Log Message:
  [lldb] Add setting for max depth of value object printing (NFC)

This adds a setting (`target.max-children-depth`) that will provide a default value for the `--depth` flag used by `expression` and `frame variable`.

The new setting uses the same default that's currently fixed in source: `UINT32_MAX`.

This provides two purposes:

1. Allowing downstream forks to provide a customized default.
2. Allowing users to set their own default.

Following `target.max-children-count`, a warning is emitted when the max depth is reached. The warning lets users know which flags or settings they can customize. This warning is shown only when the limit is the default value.


Differential Revision: https://reviews.llvm.org/D123954

More information about the All-commits mailing list