[all-commits] [llvm/llvm-project] 911756: [PATCH] Reorganize gtest integration

Konrad Kleine via All-commits all-commits at lists.llvm.org
Tue May 3 01:15:49 PDT 2022


  Branch: refs/heads/streamline
  Home:   https://github.com/llvm/llvm-project
  Commit: 911756e62f00720c3403b62054d815a8ac4dd308
      https://github.com/llvm/llvm-project/commit/911756e62f00720c3403b62054d815a8ac4dd308
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M clang/CMakeLists.txt

  Log Message:
  -----------
  [PATCH] Reorganize gtest integration


  Commit: 26e4d61303313930e5f37dfd62a10406eb8133bd
      https://github.com/llvm/llvm-project/commit/26e4d61303313930e5f37dfd62a10406eb8133bd
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M clang/lib/Driver/ToolChain.cpp
    M clang/test/Driver/netbsd.cpp

  Log Message:
  -----------
  [PATCH] ToolChain: Add -lgcc_s to the linker flags when using libc++

The libc++ build for Fedora does not include an implementation of
libunwind, so we need to explicitly link against something that
provides this implementation.


  Commit: cb8e6e7bde2ea74d07a3307cc089270d7283ebfe
      https://github.com/llvm/llvm-project/commit/cb8e6e7bde2ea74d07a3307cc089270d7283ebfe
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M clang/lib/Driver/ToolChain.cpp
    M clang/lib/Driver/ToolChains/Gnu.cpp

  Log Message:
  -----------
  [PATCH] Make -funwind-tables the default on all archs


  Commit: 71f281ee2bbdeb12bf8cd9e435edc824e24a05e4
      https://github.com/llvm/llvm-project/commit/71f281ee2bbdeb12bf8cd9e435edc824e24a05e4
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M clang/cmake/modules/AddClang.cmake

  Log Message:
  -----------
  [PATCH] Don't install static libraries


  Commit: bcc526e516e00f5cd4427f5977f0baa2e2d393f4
      https://github.com/llvm/llvm-project/commit/bcc526e516e00f5cd4427f5977f0baa2e2d393f4
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M clang/lib/Driver/ToolChains/Gnu.cpp
    M clang/lib/Driver/ToolChains/Gnu.h
    A clang/test/Driver/Inputs/fedora_28_tree/usr/lib/gcc/x86_64-linux-gnu/7/crtbegin.o
    A clang/test/Driver/Inputs/fedora_28_tree/usr/lib/gcc/x86_64-redhat-linux/7/crtbegin.o
    A clang/test/Driver/Inputs/fedora_28_tree/usr/lib/gcc/x86_64-redhat-linux/7/libgcc_s.so
    M clang/test/Driver/linux-ld.c

  Log Message:
  -----------
  [PATCH] Prefer gcc toolchains with libgcc_s.so when not static linking libgcc

Fedora ships cross-compilers on all platforms, so a user could end up
with a gcc x86_64 cross-compiler installed on an x86_64 system. clang
maintains a list of supported triples for each target and when all
else is equal will prefer toolchains with triples that appear earlier
in the list.

The cross-compiler triple on Fedora is x86_64-linux-gnu and this comes
before the Fedora system compiler's triple: x86_64-redhat-linux in
the triples list, so the cross compiler is always preferred. This
is a problem, because the cross compiler is missing libraries, like
libgcc_s.so, that clang expects to be there so linker invocations
will fail.

This patch fixes this by checking for the existence of libgcc_s.so
when it is required and taking that into account when selecting a
toolchain.


  Commit: 29a49ed780fcfd34a1fb12fe05ef02af8394b58a
      https://github.com/llvm/llvm-project/commit/29a49ed780fcfd34a1fb12fe05ef02af8394b58a
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M flang/docs/conf.py

  Log Message:
  -----------
  [PATCH] Disable use of sphinx_markdown_tables


  Commit: c8a5a0dfe1d2416b22ba5e2cd8485fa36d91ddf7
      https://github.com/llvm/llvm-project/commit/c8a5a0dfe1d2416b22ba5e2cd8485fa36d91ddf7
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M libcxx/CMakeLists.txt

  Log Message:
  -----------
  [PATCH] Remove monorepo requirement


  Commit: 9a1c187a0823bcc0c119e1ed12ab1d71d52056b1
      https://github.com/llvm/llvm-project/commit/9a1c187a0823bcc0c119e1ed12ab1d71d52056b1
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M libcxxabi/CMakeLists.txt

  Log Message:
  -----------
  [PATCH] Remove monorepo requirement


  Commit: ba26d248aa9280016d34259413df9c37b76f7819
      https://github.com/llvm/llvm-project/commit/ba26d248aa9280016d34259413df9c37b76f7819
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M openmp/runtime/src/CMakeLists.txt

  Log Message:
  -----------
  [PATCH] CMake: Make LIBOMP_HEADERS_INSTALL_PATH a cache variable when bulding standalone

This way it can be overriden on the command line.


  Commit: 5ea33d0fd269cf90a8d3c69eeb0ac57ab5d8a790
      https://github.com/llvm/llvm-project/commit/5ea33d0fd269cf90a8d3c69eeb0ac57ab5d8a790
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M lld/CMakeLists.txt

  Log Message:
  -----------
  [PATCH] CMake: Check for gtest headers even if lit.py is not present

This makes it possible to build the unittests even withotu a full
checkout of the llvm source tree.


  Commit: e9e80a636ee4e52959899f6be4f136e127db1c83
      https://github.com/llvm/llvm-project/commit/e9e80a636ee4e52959899f6be4f136e127db1c83
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    A lld/include/mach-o/compact_unwind_encoding.h

  Log Message:
  -----------
  [PATCH] Import compact_unwind_encoding.h from libunwind

This avoids an implicit cross package dependency


  Commit: bddd41020a71e79a69e470c527214c688dab6314
      https://github.com/llvm/llvm-project/commit/bddd41020a71e79a69e470c527214c688dab6314
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h

  Log Message:
  -----------
  [PATCH] Portable asm/ptrace.h include


  Commit: bb2b2a3fc2695539d40bf41824cc86a364064dd0
      https://github.com/llvm/llvm-project/commit/bb2b2a3fc2695539d40bf41824cc86a364064dd0
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M polly/lib/CMakeLists.txt

  Log Message:
  -----------
  [PATCH] Portability of subproject extension


  Commit: 13cbdadf32c5bba647136f51a2fd7ce4d0488bde
      https://github.com/llvm/llvm-project/commit/13cbdadf32c5bba647136f51a2fd7ce4d0488bde
  Author: Konrad Kleine <kkleine at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M llvm/test/tools/llvm-objdump/X86/source-interleave-prefix.test

  Log Message:
  -----------
  [PATCH] Make source-interleave-prefix test case compatible with llvm-test

llvm-test runs test from a directory that's not the upstream one, and that leads
to some false positive. Workaround this by forcing the current working
directory.


  Commit: daca98c2d159d8fdddcccf2ad58fc51782839b9e
      https://github.com/llvm/llvm-project/commit/daca98c2d159d8fdddcccf2ad58fc51782839b9e
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M flang/lib/Frontend/CMakeLists.txt
    M flang/lib/FrontendTool/CMakeLists.txt
    M flang/tools/flang-driver/CMakeLists.txt
    M flang/unittests/Frontend/CMakeLists.txt

  Log Message:
  -----------
  [PATCH] Link against libclang-cpp.so

Originally authored by Tom Stellard and modified to applicable on the
streamline.


  Commit: 1be06df4ac183244f0ddd769deb82d1fd966404e
      https://github.com/llvm/llvm-project/commit/1be06df4ac183244f0ddd769deb82d1fd966404e
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M compiler-rt/lib/fuzzer/FuzzerDriver.cpp

  Log Message:
  -----------
  [PATCH] Workaround libstdc++ limitation wrt. thread copy


  Commit: c6fb11e3eca9cc68e828377ae97f6387f6dd44ea
      https://github.com/llvm/llvm-project/commit/c6fb11e3eca9cc68e828377ae97f6387f6dd44ea
  Author: Konrad Kleine <kkleine at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M compiler-rt/CMakeLists.txt
    M compiler-rt/lib/builtins/CMakeLists.txt

  Log Message:
  -----------
  [PATCH] Help compiler-rt find shared LLVM cmake files from llvm-cmake package


  Commit: 5a378cf4c36c1f7f5ebba8614a836a97dbba432f
      https://github.com/llvm/llvm-project/commit/5a378cf4c36c1f7f5ebba8614a836a97dbba432f
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M llvm/unittests/Support/CrashRecoveryTest.cpp

  Log Message:
  -----------
  [PATCH] Disable CrashRecoveryTest.DumpStackCleanup test on aarch64

Produces a non-reproducible failure on aarch64:
https://bugzilla.redhat.com/show_bug.cgi?id=2048440


  Commit: 6bfc20c4d548174830697f6988682bcc937465f3
      https://github.com/llvm/llvm-project/commit/6bfc20c4d548174830697f6988682bcc937465f3
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M llvm/test/DebugInfo/Generic/missing-abstract-variable.ll

  Log Message:
  -----------
  [PATCH] XFAIL missing-abstract-variable.ll test on ppc64le

It's seems the strategy with this test is to XFAIL it on all
architectures that it fails on.  I wonder if we should be passing
it a specific triple?  Also, from what I can tell, this tests only
runs when llvm is configured with LLVM_DEFAULT_TARGET_TRIPLE set
to a non-empty value, which is why it may not fail in every build
configuration.

Differential Revision: https://reviews.llvm.org/D109806


  Commit: 940ff48ca3a8557201e273fc116905e57e797c05
      https://github.com/llvm/llvm-project/commit/940ff48ca3a8557201e273fc116905e57e797c05
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M clang/lib/Driver/ToolChains/Gnu.cpp

  Log Message:
  -----------
  [PATCH] Driver: Add a gcc equivalent triple to the list of triples to search

There are some gcc triples, like x86_64-redhat-linux, that provide the
same behavior as a clang triple with a similar name (e.g.
x86_64-redhat-linux-gnu). When searching for a gcc install, also search
for a gcc equivalent triple if one exists.

https://reviews.llvm.org/D111207


  Commit: 85a24eec4ca82cc18e71e288860c7ba442d8c152
      https://github.com/llvm/llvm-project/commit/85a24eec4ca82cc18e71e288860c7ba442d8c152
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M clang/lib/Sema/DeclSpec.cpp

  Log Message:
  -----------
  [PATCH] Work around gcc miscompile

This works around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104334,
which miscompiles clang on s390x and ppc64le. The issue is already
fixed on the gcc side, but including this as a temporary workaround
to get a working build.


  Commit: 57916dbabd8305c970b7726fd641750bfb086a60
      https://github.com/llvm/llvm-project/commit/57916dbabd8305c970b7726fd641750bfb086a60
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M clang/tools/clang-shlib/CMakeLists.txt

  Log Message:
  -----------
  [PATCH] cmake: Allow shared libraries to customize the soname using LLVM_ABI_REVISION

The LLVM_ABI_REVISION variable is intended to be used for release
candidates which introduce an ABI change to a shared library.  This
variable can be specified per library, so there is not one global value
for all of LLVM.

For example, if we LLVM X.0.0-rc2 introduces an ABI change for a library
compared with LLVM X.0.0-rc1, then the LLVM_ABI_REVISION number for
library will be incremented by 1.

In the main branch, LLVM_ABI_REVISION should always be 0, it is only
meant to be used in the release branch.

Differential Revision: https://reviews.llvm.org/D105594


  Commit: 38a08f9bbeee0a97b06e94d7309dfede9c76b29d
      https://github.com/llvm/llvm-project/commit/38a08f9bbeee0a97b06e94d7309dfede9c76b29d
  Author: Konrad Kleine <kkleine at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M llvm/lib/Transforms/Hello/CMakeLists.txt
    M llvm/tools/bugpoint-passes/CMakeLists.txt
    M llvm/unittests/Passes/CMakeLists.txt

  Log Message:
  -----------
  [PATCH] Revert "cmake: Don't install plugins used for examples or tests"

This reverts commit d0a767608773cfa3d8644c27796b63ff40962806.

By reverting this we fix these errors:

CMake Error at /usr/lib64/cmake/llvm/AddLLVM.cmake:1821 (add_dependencies):
  The dependency target "LLVMHello" of target "check-all" does not exist.
Call Stack (most recent call first):
  CMakeLists.txt:578 (add_lit_target)

CMake Error at /usr/lib64/cmake/llvm/AddLLVM.cmake:1821 (add_dependencies):
  The dependency target "LLVMHello" of target "check-clang-tools" does not
  exist.
Call Stack (most recent call first):
  /usr/lib64/cmake/llvm/AddLLVM.cmake:1842 (add_lit_target)
  /builddir/build/BUILD/clang-tools-extra-15.0.0.src/test/CMakeLists.txt:110 (add_lit_testsuite)

CMake Error at /usr/lib64/cmake/llvm/AddLLVM.cmake:1821 (add_dependencies):
  The dependency target "LLVMHello" of target "check-clang-extra-unit" does
  not exist.
Call Stack (most recent call first):
  /usr/lib64/cmake/llvm/AddLLVM.cmake:1877 (add_lit_target)
  /builddir/build/BUILD/clang-tools-extra-15.0.0.src/test/CMakeLists.txt:118 (add_lit_testsuites)


  Commit: d022552769305b1eeadfbda184de649fe1f33968
      https://github.com/llvm/llvm-project/commit/d022552769305b1eeadfbda184de649fe1f33968
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M clang-tools-extra/test/CMakeLists.txt
    M clang-tools-extra/test/lit.site.cfg.py.in
    M clang/CMakeLists.txt
    M clang/lib/Analysis/plugins/CMakeLists.txt
    M clang/test/CMakeLists.txt
    M clang/test/lit.site.cfg.py.in
    M clang/tools/driver/CMakeLists.txt

  Log Message:
  -----------
  [PATCH] Revert "replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests"

This reverts commit 76cad51ba700233d6e3492eddcbb466b6adbc2eb.

We don't install the LLVMHello plugin, so tests should not depend on it.


  Commit: 9dd5352b7ec7cd751bd42fc225d066d3f7fd3ce3
      https://github.com/llvm/llvm-project/commit/9dd5352b7ec7cd751bd42fc225d066d3f7fd3ce3
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M clang-tools-extra/clang-tidy/tool/CMakeLists.txt
    M clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp
    M clang-tools-extra/docs/clang-tidy/Contributing.rst
    M clang-tools-extra/docs/clang-tidy/index.rst
    M clang-tools-extra/test/CMakeLists.txt
    R clang-tools-extra/test/clang-tidy/CTTestTidyModule.cpp
    M clang-tools-extra/test/lit.cfg.py
    M clang-tools-extra/test/lit.site.cfg.py.in

  Log Message:
  -----------
  [PATCH] Revert "Reland "enable plugins for clang-tidy""

This reverts commit 84f137a590e7de25c4105303e5938c40566c2dfb.

We don't install the LLVMHello plugin so tests should not depend on it.


  Commit: 10dfad2deedf872907b8131d8c29325c1b3b3745
      https://github.com/llvm/llvm-project/commit/10dfad2deedf872907b8131d8c29325c1b3b3745
  Author: Konrad Kleine <kkleine at redhat.com>
  Date:   2022-05-03 (Tue, 03 May 2022)

  Changed paths:
    M clang/include/clang/Driver/ToolChain.h
    M clang/test/CodeGen/dwarf-version.c
    M clang/test/Driver/cl-options.c
    M clang/test/Driver/ve-toolchain.c
    M clang/test/Driver/ve-toolchain.cpp

  Log Message:
  -----------
  [PATCH][clang]Produce DWARF4 by default

Have a look at the following commit to see when the move from DWARF 4 to 5 first happened upstream:

https://github.com/llvm/llvm-project/commit/d3b26dea16108c427b19b5480c9edc76edf8f5b4?diff=unified


Compare: https://github.com/llvm/llvm-project/compare/911756e62f00%5E...10dfad2deedf


More information about the All-commits mailing list