[all-commits] [llvm/llvm-project] e53019: [lldb] Make GetSharedModuleWithLocalCache consider...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Mon May 2 21:07:33 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e53019a8ff778048dd83aee29dd659af8b771920
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2022-05-02 (Mon, 02 May 2022)

  Changed paths:
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwinDevice.cpp

  Log Message:
  [lldb] Make GetSharedModuleWithLocalCache consider the device support directory

Make GetSharedModuleWithLocalCache consider the device support
directory. In the past we only needed the device support directory to
debug remote processes. Since the introduction of Apple Silicon and
Rosetta this stopped being true.

When debugging a Rosetta process on macOS we need to consider the
Rosetta expanded shared cache. This patch and it dependencies move that
logic out of PlatfromRemoteDarwinDevice into a new abstract class called
PlatfromDarwinDevice. The new platform sit in between PlatformDarwin and
PlatformMacOSX and PlatformRemoteDarwinDevice and has all the necessary
logic to deal with the device support directory.

Technically I could have moved everything in PlatfromDarwinDevice into
PlatfromDarwin but decided that this logic is sufficiently self
contained that it warrants its own abstraction.


Differential revision: https://reviews.llvm.org/D124801

More information about the All-commits mailing list