[all-commits] [llvm/llvm-project] 7047c4: [VecCombine] Fix sort comparator logic in foldShuf...

David Green via All-commits all-commits at lists.llvm.org
Fri Apr 29 01:30:22 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7047c47918a6f84a2d5a1e63882f5af4cafb43a4
      https://github.com/llvm/llvm-project/commit/7047c47918a6f84a2d5a1e63882f5af4cafb43a4
  Author: David Green <david.green at arm.com>
  Date:   2022-04-29 (Fri, 29 Apr 2022)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/VectorCombine.cpp

  Log Message:
  -----------
  [VecCombine] Fix sort comparator logic in foldShuffleFromReductions

I think this sort comparator was overly complex, and the windows
expensive check bot agreed, failing as it was not giving a strict weak
ordering. Change it to use the comparison of the mask values as unsigned
integers. This should sort the undef elements to the end whilst keeping
X<Y otherwise.




More information about the All-commits mailing list