[all-commits] [llvm/llvm-project] db1cec: [X86] Fix CodeGen Module Flag for -mibt-seal

[João Moreira via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: db1cec371c00722ce42683e0dc8a2021186332c5
      https://github.com/llvm/llvm-project/commit/db1cec371c00722ce42683e0dc8a2021186332c5
  Author: Joao Moreira <joao.moreira at intel.com>
  Date:   2022-04-29 (Fri, 29 Apr 2022)

  Changed paths:
    M clang/lib/Frontend/CompilerInvocation.cpp
    M clang/test/CodeGen/X86/x86-cf-protection.c

  Log Message:
  -----------
  [X86] Fix CodeGen Module Flag for -mibt-seal

When assertions are enabled, clang will perform RoundTrip for CompilerInvocation argument generation. ibt-seal flags are currently missing in this argument generation, and because of that, the feature doesn't get enabled for these cases. Performing RoundTrip is the default for assert builds, rendering the feature broken in these scenarios.

This patch fixes this and adds a test to properly verify that modules are  being generated with the flag when -mibt-seal is used.

Please, add any known relevant reviewer which I may have missed.

[1] - https://reviews.llvm.org/D116070

Reviewed By: pengfei, gftg, aaron.ballman, nickdesaulniers

Differential Revision: https://reviews.llvm.org/D118052