[all-commits] [llvm/llvm-project] 0d6b57: [HLSL] Adjust access specifier behavior

Chris B via All-commits all-commits at lists.llvm.org
Thu Apr 28 08:38:04 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0d6b574b8717a44cda565baa756875f762fa60b9
      https://github.com/llvm/llvm-project/commit/0d6b574b8717a44cda565baa756875f762fa60b9
  Author: Chris Bieneman <chris.bieneman at me.com>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticGroups.td
    M clang/include/clang/Basic/DiagnosticParseKinds.td
    M clang/lib/Parse/ParseDeclCXX.cpp
    M clang/lib/Sema/SemaDeclCXX.cpp
    A clang/test/ParserHLSL/access_specifiers.hlsl

  Log Message:
  -----------
  [HLSL] Adjust access specifier behavior

HLSL doesn't support access specifiers. This change has two components:

1) Make default access for classes public
2) Diagnose the use of access specifiers as a clang HLSL extension

As long as the default behavior for access specifiers matches HLSL,
allowing them to be used doesn't cause sourece incompatability with
valid code. As such enabling them as a clang extension seems like a
reasonable approach.

Fixes #55124

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D124487




More information about the All-commits mailing list