[all-commits] [llvm/llvm-project] b809c4: [lldb] Add FixAnyAddress to ABI plugins

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b809c4cdb70a100c85524555a14332f22ede1b7a
      https://github.com/llvm/llvm-project/commit/b809c4cdb70a100c85524555a14332f22ede1b7a
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2022-04-28 (Thu, 28 Apr 2022)

  Changed paths:
    M lldb/include/lldb/Target/ABI.h
    M lldb/source/Commands/CommandObjectMemory.cpp
    M lldb/source/Target/Process.cpp

  Log Message:
  -----------
  [lldb] Add FixAnyAddress to ABI plugins

FixAnyAddress is to be used when we don't know or don't care
whether we're fixing a code or data address.

By using FixAnyAddress over the others, you document that no
specific choice was made.

On all existing platforms apart from Arm Thumb, you could use
either FixCodeAddress or FixDataAddress and be fine. Up until
now I've chosen to use FixDataAddress but if I had
chosen to use FixCodeAddress that would have broken Arm Thumb.

Hence FixAnyAddress, to give you the "safest" option when you're
in generic code.

Uses of FixDataAddress in memory region code have been changed
to FixAnyAddress. The functionality is unchanged.

Reviewed By: omjavaid, JDevlieghere

Differential Revision: https://reviews.llvm.org/D124000