[all-commits] [llvm/llvm-project] f513b5: [lldb] Make test names unique

Pavel Labath via All-commits all-commits at lists.llvm.org
Wed Apr 27 06:09:48 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f513b5fc47df5c040a257ab6f4643942828fa610
      https://github.com/llvm/llvm-project/commit/f513b5fc47df5c040a257ab6f4643942828fa610
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2022-04-27 (Wed, 27 Apr 2022)

  Changed paths:
    R lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py
    A lldb/test/API/symbol_ondemand/shared_library/TestSharedLibOnDemand.py

  Log Message:
  -----------
  [lldb] Make test names unique


  Commit: 089a1d9deba5579487d77c97241b3f9e5e3d4745
      https://github.com/llvm/llvm-project/commit/089a1d9deba5579487d77c97241b3f9e5e3d4745
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2022-04-27 (Wed, 27 Apr 2022)

  Changed paths:
    M lldb/test/API/lang/cpp/limit-debug-info/Makefile
    M lldb/test/API/lang/cpp/limit-debug-info/TestWithLimitDebugInfo.py
    M lldb/test/API/lang/cpp/limit-debug-info/base.cpp
    M lldb/test/API/lang/cpp/limit-debug-info/base.h
    M lldb/test/API/lang/cpp/limit-debug-info/derived.cpp
    M lldb/test/API/lang/cpp/limit-debug-info/derived.h
    M lldb/test/API/lang/cpp/limit-debug-info/main.cpp

  Log Message:
  -----------
  [lldb] Fix TestWithLimitDebugInfo.py

The test was broken (in the sense that it was not testing what it was
supposed to test) in two ways:
- a Makefile refactor caused it to stop being built with
  -flimit-debug-info
- clang's constructor homing changed the "home" of the type

This patch fixes the Makefile, and modifies the source code to produce
the same result with both type homing strategies. Due to constructor
homing I had to use a different implicitly-defined function for the test
-- I chose the assignment operator.

I also added some sanity checks to the test to ensure that the test is
indeed operating on limited debug info.


Compare: https://github.com/llvm/llvm-project/compare/51be0925b42e...089a1d9deba5


More information about the All-commits mailing list