[all-commits] [llvm/llvm-project] 5b3ca2: [demangler] Simplify OutputBuffer initialization

[Nathan Sidwell via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5b3ca24a35e91bf9c19af856e7f92c69b17f989e
      https://github.com/llvm/llvm-project/commit/5b3ca24a35e91bf9c19af856e7f92c69b17f989e
  Author: Nathan Sidwell <nathan at acm.org>
  Date:   2022-04-26 (Tue, 26 Apr 2022)

  Changed paths:
    M libcxxabi/src/cxa_demangle.cpp
    M libcxxabi/src/demangle/Utility.h
    M llvm/include/llvm/Demangle/Utility.h
    M llvm/lib/Demangle/DLangDemangle.cpp
    M llvm/lib/Demangle/ItaniumDemangle.cpp
    M llvm/lib/Demangle/MicrosoftDemangle.cpp
    M llvm/lib/Demangle/MicrosoftDemangleNodes.cpp
    M llvm/lib/Demangle/RustDemangle.cpp

  Log Message:
  -----------
  [demangler] Simplify OutputBuffer initialization

Every non-testcase use of OutputBuffer contains code to allocate an
initial buffer (using either 128 or 1024 as initial guesses). There's
now no need to do that, given recent changes to the buffer extension
heuristics -- it allocates a 1k(ish) buffer on first need.

Just pass in a buffer (if any) to the constructor.  Thus the
OutputBuffer's ownership of the buffer starts at its own lifetime
start. We can reduce the lifetime of this object in several cases.

That new constructor takes a 'size_t *' for the size argument, as all
uses with a non-null buffer are passing through a malloc'd buffer from
their own caller in this manner.

The buffer reset member function is never used, and is deleted.

The original buffer initialization code would return a failure code if
that first malloc failed.  Existing code either ignored that, called
std::terminate with a FIXME, or returned an error code.

But that's not foolproof anyway, as a subsequent buffer extension
failure ends up calling std::terminate. I am working on addressing
that unfortunate failure mode in a manner more consistent with the C++
ABI design.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D122604