[all-commits] [llvm/llvm-project] 5db925: Reapply D124184, [DebugInfo][InstrRef] Add a size ...

Jeremy Morse via All-commits all-commits at lists.llvm.org
Mon Apr 25 07:50:51 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5db925023169f8a19419e68153682d1e518f8392
      https://github.com/llvm/llvm-project/commit/5db925023169f8a19419e68153682d1e518f8392
  Author: Jeremy Morse <jeremy.morse at sony.com>
  Date:   2022-04-25 (Mon, 25 Apr 2022)

  Changed paths:
    M llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
    M llvm/lib/CodeGen/LiveDebugVariables.cpp
    A llvm/test/DebugInfo/MIR/InstrRef/dbg-phis-in-ldv2.mir
    A llvm/test/DebugInfo/MIR/InstrRef/phi-on-stack-coalesced.mir
    A llvm/test/DebugInfo/MIR/InstrRef/phi-on-stack-coalesced2.mir
    M llvm/test/DebugInfo/MIR/InstrRef/phi-regallocd-to-stack.mir
    M llvm/unittests/CodeGen/InstrRefLDVTest.cpp

  Log Message:
  -----------
  Reapply D124184, [DebugInfo][InstrRef] Add a size operand to DBG_PHI

This was applied in fda4305e53784, reverted in 13815e8cbf8d49, the problem
was that fp80 X86 registers that were spilt to the stack aren't expected by
LiveDebugValues. It pre-allocates a position number for all register sizes
that can be spilt, and 80 bits isn't exactly common.

The solution is to scan the register classes to find any unrecognised
register sizes, adn pre-allocate those position numbers, avoiding a later
assertion.




More information about the All-commits mailing list