[all-commits] [llvm/llvm-project] 4c807f: [mlir][vector] insert `alloca`s outside of loops

[ftynse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4c807f2f579f4e5412c49c341230e309f2f79c9b
      https://github.com/llvm/llvm-project/commit/4c807f2f579f4e5412c49c341230e309f2f79c9b
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2022-04-25 (Mon, 25 Apr 2022)

  Changed paths:
    M mlir/lib/Dialect/Vector/Transforms/VectorTransferSplitRewritePatterns.cpp
    M mlir/test/Dialect/Vector/vector-transfer-full-partial-split.mlir

  Log Message:
  -----------
  [mlir][vector] insert `alloca`s outside of loops

After https://reviews.llvm.org/D119743 added the `AutomaticAllocationScope`
trait to loop-like constructs, the vector transfer full/partial splitting pass
started inserting allocations for temporaries within the closest loop rather
than the closest function (or other allocation scope such as `async.execute`).
While this is correct as long as the lowered code takes care of automatic
deallocation at the end of each iteration of the loop, this interferes with
downstream optimizations that expect `alloca`s to be at the function level.
Step over loops when looking for the closest allocation scope in vector
transfer full/partial splitting pass thus restoring the original behavior.

Reviewed By: hanchung

Differential Revision: https://reviews.llvm.org/D124366