[all-commits] [llvm/llvm-project] 3254f4: [lld/mac] For catalyst outputs, tolerate implicitl...

[Nico Weber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3254f46884d3ec2d6112ab49ba3c470906699cda
      https://github.com/llvm/llvm-project/commit/3254f46884d3ec2d6112ab49ba3c470906699cda
  Author: Nico Weber <thakis at chromium.org>
  Date:   2022-04-23 (Sat, 23 Apr 2022)

  Changed paths:
    M lld/MachO/Driver.cpp
    M lld/MachO/Driver.h
    M lld/MachO/DriverUtils.cpp
    M lld/MachO/InputFiles.cpp
    M lld/MachO/InputFiles.h
    A lld/test/MachO/Inputs/MacOSX.sdk/System/Library/Frameworks/MacOnly-Indirect.framework/MacOnly-Indirect.tbd
    A lld/test/MachO/Inputs/MacOSX.sdk/System/Library/Frameworks/MacOnly.framework/MacOnly.tbd
    M lld/test/MachO/zippered.yaml

  Log Message:
  -----------
  [lld/mac] For catalyst outputs, tolerate implicitly linking against mac-only tbd files

Before this,

  clang empty.cc -target x86_64-apple-ios13.1-macabi \
      -framework CoreServices -fuse-ld=lld

would error out with

    ld64.lld: error: path/to/MacOSX.sdk/System/Library/Frameworks/
         CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/
         Versions/A/CarbonCore.tbd(
             /System/Library/Frameworks/
             CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/
             Versions/A/CarbonCore) is incompatible with x86_64 (macCatalyst)

Now it works, like with ld64.

Differential Revision: https://reviews.llvm.org/D124336