[all-commits] [llvm/llvm-project] d17962: Fix sanitizer stack traces on aarch64.

Roy Sundahl via All-commits all-commits at lists.llvm.org
Thu Apr 21 14:28:14 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d179627ef012f061a9186c9f026a3f0ec771c3e9
      https://github.com/llvm/llvm-project/commit/d179627ef012f061a9186c9f026a3f0ec771c3e9
  Author: Roy Sundahl <rsundahl at apple.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_mac.cpp

  Log Message:
  -----------
  Fix sanitizer stack traces on aarch64.

Fixes llvm-project/compiler-rt/test/asan/TestCases/null_deref.cpp on
macOS/aarch64.

The bp (base pointer) variable was being loaded from register LR and
not FP on aarch64 (except for this narrow case):
defined(__IPHONE_8_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_8_0

Without a valid bp from the FP register, it is not possible to traverse
previous frames for a complete stack trace. The rationale for fetching
the LR as the bp for all cases except above is not clear but since the
FP register is the canonical register for use as the frame pointer, this
commit removes the restriction above for unconditional use all aarch64.

rdar://91587039

Differential Revision: https://reviews.llvm.org/D124140




More information about the All-commits mailing list